From a8bc558a606266b2dc1d1c19cf0c052f3b733679 Mon Sep 17 00:00:00 2001
From: Till <2353100+S7evinK@users.noreply.github.com>
Date: Fri, 14 Oct 2022 10:38:12 +0200
Subject: [PATCH] Always add `UnreadNotifications` to joined room reponses
 (#2793)

Fixes a minor bug, where we failed to add `UnreadNotifications` to the
join response, if it wasn't in
`GetUserUnreadNotificationCountsForRooms`.
---
 syncapi/streams/stream_notificationdata.go | 3 ++-
 syncapi/types/types.go                     | 8 +++++---
 sytest-whitelist                           | 4 +++-
 3 files changed, 10 insertions(+), 5 deletions(-)

diff --git a/syncapi/streams/stream_notificationdata.go b/syncapi/streams/stream_notificationdata.go
index 5a81fd09..66ee0ded 100644
--- a/syncapi/streams/stream_notificationdata.go
+++ b/syncapi/streams/stream_notificationdata.go
@@ -3,6 +3,7 @@ package streams
 import (
 	"context"
 
+	"github.com/matrix-org/dendrite/internal/eventutil"
 	"github.com/matrix-org/dendrite/syncapi/storage"
 	"github.com/matrix-org/dendrite/syncapi/types"
 )
@@ -53,7 +54,7 @@ func (p *NotificationDataStreamProvider) IncrementalSync(
 	for roomID, jr := range req.Response.Rooms.Join {
 		counts := countsByRoom[roomID]
 		if counts == nil {
-			continue
+			counts = &eventutil.NotificationData{}
 		}
 		jr.UnreadNotifications = &types.UnreadNotifications{
 			HighlightCount:    counts.UnreadHighlightCount,
diff --git a/syncapi/types/types.go b/syncapi/types/types.go
index 60a74a28..57ce7b6f 100644
--- a/syncapi/types/types.go
+++ b/syncapi/types/types.go
@@ -492,9 +492,11 @@ func (jr JoinResponse) MarshalJSON() ([]byte, error) {
 		}
 
 	}
-	if jr.UnreadNotifications != nil &&
-		jr.UnreadNotifications.NotificationCount == 0 && jr.UnreadNotifications.HighlightCount == 0 {
-		a.UnreadNotifications = nil
+	if jr.UnreadNotifications != nil {
+		// if everything else is nil, also remove UnreadNotifications
+		if a.State == nil && a.Ephemeral == nil && a.AccountData == nil && a.Timeline == nil && a.Summary == nil {
+			a.UnreadNotifications = nil
+		}
 	}
 	return json.Marshal(a)
 }
diff --git a/sytest-whitelist b/sytest-whitelist
index 2bd8b940..93d447d2 100644
--- a/sytest-whitelist
+++ b/sytest-whitelist
@@ -744,4 +744,6 @@ User in remote room doesn't appear in user directory after server left room
 User in shared private room does appear in user directory until leave
 Existing members see new member's presence
 Inbound federation can return missing events for joined visibility
-outliers whose auth_events are in a different room are correctly rejected
\ No newline at end of file
+outliers whose auth_events are in a different room are correctly rejected
+Messages that notify from another user increment notification_count
+Messages that highlight from another user increment unread highlight count
\ No newline at end of file