mirror of
https://github.com/1f349/dendrite.git
synced 2024-11-10 06:53:00 +00:00
c31cb02271
* bugfix: Fix a race condition when creating guest accounts It was possible to both select the same next numeric ID and then both attempt to INSERT this into the table. This would cause a UNIQUE violation which then presented itself as an error in sqlite because it does not implement `common.IsUniqueConstraintViolationErr`. The fix here is NOT to implement `common.IsUniqueConstraintViolationErr` otherwise the 2 users would get the SAME guest account. Instead, all of these operations should be done inside a transaction. This is what this PR does. * Update postgres * Typo * Actually use the txn when creating accounts * bugfix for database is locked on guest reg
108 lines
3.1 KiB
Go
108 lines
3.1 KiB
Go
// Copyright 2017 Vector Creations Ltd
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
package postgres
|
|
|
|
import (
|
|
"context"
|
|
"database/sql"
|
|
|
|
"github.com/matrix-org/dendrite/clientapi/auth/authtypes"
|
|
)
|
|
|
|
const profilesSchema = `
|
|
-- Stores data about accounts profiles.
|
|
CREATE TABLE IF NOT EXISTS account_profiles (
|
|
-- The Matrix user ID localpart for this account
|
|
localpart TEXT NOT NULL PRIMARY KEY,
|
|
-- The display name for this account
|
|
display_name TEXT,
|
|
-- The URL of the avatar for this account
|
|
avatar_url TEXT
|
|
);
|
|
`
|
|
|
|
const insertProfileSQL = "" +
|
|
"INSERT INTO account_profiles(localpart, display_name, avatar_url) VALUES ($1, $2, $3)"
|
|
|
|
const selectProfileByLocalpartSQL = "" +
|
|
"SELECT localpart, display_name, avatar_url FROM account_profiles WHERE localpart = $1"
|
|
|
|
const setAvatarURLSQL = "" +
|
|
"UPDATE account_profiles SET avatar_url = $1 WHERE localpart = $2"
|
|
|
|
const setDisplayNameSQL = "" +
|
|
"UPDATE account_profiles SET display_name = $1 WHERE localpart = $2"
|
|
|
|
type profilesStatements struct {
|
|
insertProfileStmt *sql.Stmt
|
|
selectProfileByLocalpartStmt *sql.Stmt
|
|
setAvatarURLStmt *sql.Stmt
|
|
setDisplayNameStmt *sql.Stmt
|
|
}
|
|
|
|
func (s *profilesStatements) prepare(db *sql.DB) (err error) {
|
|
_, err = db.Exec(profilesSchema)
|
|
if err != nil {
|
|
return
|
|
}
|
|
if s.insertProfileStmt, err = db.Prepare(insertProfileSQL); err != nil {
|
|
return
|
|
}
|
|
if s.selectProfileByLocalpartStmt, err = db.Prepare(selectProfileByLocalpartSQL); err != nil {
|
|
return
|
|
}
|
|
if s.setAvatarURLStmt, err = db.Prepare(setAvatarURLSQL); err != nil {
|
|
return
|
|
}
|
|
if s.setDisplayNameStmt, err = db.Prepare(setDisplayNameSQL); err != nil {
|
|
return
|
|
}
|
|
return
|
|
}
|
|
|
|
func (s *profilesStatements) insertProfile(
|
|
ctx context.Context, txn *sql.Tx, localpart string,
|
|
) (err error) {
|
|
_, err = txn.Stmt(s.insertProfileStmt).ExecContext(ctx, localpart, "", "")
|
|
return
|
|
}
|
|
|
|
func (s *profilesStatements) selectProfileByLocalpart(
|
|
ctx context.Context, localpart string,
|
|
) (*authtypes.Profile, error) {
|
|
var profile authtypes.Profile
|
|
err := s.selectProfileByLocalpartStmt.QueryRowContext(ctx, localpart).Scan(
|
|
&profile.Localpart, &profile.DisplayName, &profile.AvatarURL,
|
|
)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
return &profile, nil
|
|
}
|
|
|
|
func (s *profilesStatements) setAvatarURL(
|
|
ctx context.Context, localpart string, avatarURL string,
|
|
) (err error) {
|
|
_, err = s.setAvatarURLStmt.ExecContext(ctx, avatarURL, localpart)
|
|
return
|
|
}
|
|
|
|
func (s *profilesStatements) setDisplayName(
|
|
ctx context.Context, localpart string, displayName string,
|
|
) (err error) {
|
|
_, err = s.setDisplayNameStmt.ExecContext(ctx, displayName, localpart)
|
|
return
|
|
}
|