mirror of
https://github.com/1f349/dendrite.git
synced 2024-11-10 06:53:00 +00:00
c31cb02271
* bugfix: Fix a race condition when creating guest accounts It was possible to both select the same next numeric ID and then both attempt to INSERT this into the table. This would cause a UNIQUE violation which then presented itself as an error in sqlite because it does not implement `common.IsUniqueConstraintViolationErr`. The fix here is NOT to implement `common.IsUniqueConstraintViolationErr` otherwise the 2 users would get the SAME guest account. Instead, all of these operations should be done inside a transaction. This is what this PR does. * Update postgres * Typo * Actually use the txn when creating accounts * bugfix for database is locked on guest reg |
||
---|---|---|
.. | ||
postgres | ||
sqlite3 | ||
interface.go | ||
storage_wasm.go | ||
storage.go |