mirror of
https://github.com/1f349/dendrite.git
synced 2024-09-19 18:36:53 +01:00
d5dbe546e4
* Always defer *sql.Rows.Close and consult with Err database/sql.Rows.Next() makes sure to call Close only after exhausting result rows which would NOT happen when returning early from a bad Scan. Close being idempotent makes it a great candidate to get always deferred regardless of what happens later on the result set. This change also makes sure call Err() after exhausting Next() and propagate non-nil results from it as the documentation advises. Closes #764 Signed-off-by: Kiril Vladimiroff <kiril@vladimiroff.org> * Override named result parameters in last returns Signed-off-by: Kiril Vladimiroff <kiril@vladimiroff.org> * Do the same over new changes that got merged Signed-off-by: Kiril Vladimiroff <kiril@vladimiroff.org> Co-authored-by: Neil Alexander <neilalexander@users.noreply.github.com> |
||
|---|---|---|
| .. | ||
| basecomponent | ||
| config | ||
| http | ||
| keydb | ||
| test | ||
| transactions | ||
| consumers.go | ||
| eventcontent.go | ||
| events.go | ||
| httpapi.go | ||
| log.go | ||
| partition_offset_table.go | ||
| routing.go | ||
| sql.go | ||
| types.go | ||