From 2281ef31f1106eac529b8c511fd4ea2cae310cc0 Mon Sep 17 00:00:00 2001 From: Captain ALM Date: Thu, 26 Sep 2024 21:31:44 +0100 Subject: [PATCH] Add error returning for missing error output paths. --- internal/server.go | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/internal/server.go b/internal/server.go index f9d1f7a..2fe2e50 100644 --- a/internal/server.go +++ b/internal/server.go @@ -187,9 +187,8 @@ func NewPropFindResponse(path string, propfind *PropFind, props map[xml.Name]Pro code := http.StatusOK if err != nil { - // TODO: don't throw away error message here code = HTTPErrorFromError(err).Code - val = emptyVal + val = NewRawXMLElement(xmlName, []xml.Attr{{Name: xml.Name{Space: "ERR", Local: "Error"}, Value: err.Error()}}, nil) } if err := resp.EncodeProp(code, val); err != nil { @@ -210,8 +209,8 @@ func NewPropFindResponse(path string, propfind *PropFind, props map[xml.Name]Pro f, ok := props[xmlName] if ok { if v, err := f(&raw); err != nil { - // TODO: don't throw away error message here code = HTTPErrorFromError(err).Code + val = NewRawXMLElement(xmlName, []xml.Attr{{Name: xml.Name{Space: "ERR", Local: "Error"}, Value: err.Error()}}, nil) } else { code = http.StatusOK val = v