1f349/go-webdav
4
0
Fork 0
mirror of https://github.com/1f349/go-webdav.git synced 2025-04-04 03:05:03 +01:00
Code Issues Packages Projects Releases Wiki Activity

Add error returning for missing error output paths.

Browse Source
This commit is contained in:
Captain ALM 2024-09-26 21:31:44 +01:00
parent 9094f8327e
commit 2281ef31f1
Signed by: alfred
GPG Key ID: 4E4ADD02609997B1
1 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
internal/server.go
View File

@ -187,9 +187,8 @@ func NewPropFindResponse(path string, propfind *PropFind, props map[xml.Name]Pro
code := http.StatusOK code := http.StatusOK
if err != nil { if err != nil {
// TODO: don't throw away error message here
code = HTTPErrorFromError(err).Code code = HTTPErrorFromError(err).Code
val = emptyVal val = NewRawXMLElement(xmlName, []xml.Attr{{Name: xml.Name{Space: "ERR", Local: "Error"}, Value: err.Error()}}, nil)
} }
if err := resp.EncodeProp(code, val); err != nil { if err := resp.EncodeProp(code, val); err != nil {
@ -210,8 +209,8 @@ func NewPropFindResponse(path string, propfind *PropFind, props map[xml.Name]Pro
f, ok := props[xmlName] f, ok := props[xmlName]
if ok { if ok {
if v, err := f(&raw); err != nil { if v, err := f(&raw); err != nil {
// TODO: don't throw away error message here
code = HTTPErrorFromError(err).Code code = HTTPErrorFromError(err).Code
val = NewRawXMLElement(xmlName, []xml.Attr{{Name: xml.Name{Space: "ERR", Local: "Error"}, Value: err.Error()}}, nil)
} else { } else {
code = http.StatusOK code = http.StatusOK
val = v val = v