internal: read response body on error

This commit is contained in:
Simon Ser 2020-02-12 19:46:05 +01:00
parent a892cc58df
commit 30eac28d2b
No known key found for this signature in database
GPG Key ID: 0FDE7BE0E88F5E48

View File

@ -77,9 +77,21 @@ func (c *Client) Do(req *http.Request) (*http.Response, error) {
return nil, err return nil, err
} }
if resp.StatusCode/100 != 2 { if resp.StatusCode/100 != 2 {
// TODO: if body is plaintext, read it and populate the error message var wrappedErr error
resp.Body.Close() if strings.HasPrefix(resp.Header.Get("Content-Type"), "text/") {
return nil, &HTTPError{Code: resp.StatusCode} // TODO: if body is plaintext, read it and populate the error message
lr := io.LimitedReader{R: resp.Body, N: 1024}
var buf bytes.Buffer
io.Copy(&buf, &lr)
resp.Body.Close()
if s := strings.TrimSpace(buf.String()); s != "" {
if lr.N == 0 {
s += " […]"
}
wrappedErr = fmt.Errorf("%v", s)
}
}
return nil, &HTTPError{Code: resp.StatusCode, Err: wrappedErr}
} }
return resp, nil return resp, nil
} }