From 7d337ac048de84dd910fa84d7b8547dc7a432533 Mon Sep 17 00:00:00 2001 From: Sebastien Binet Date: Fri, 15 Dec 2023 14:49:18 +0100 Subject: [PATCH] internal: fix always-true interface comparison This CL corrects the following bug uncovered by staticcheck: ``` internal/elements.go:148:6: this comparison is always true (SA4023) internal/elements.go:146:18: the lhs of the comparison gets its value from here and has a concrete type ``` Signed-off-by: Sebastien Binet --- internal/elements.go | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/internal/elements.go b/internal/elements.go index 786922e..db7d960 100644 --- a/internal/elements.go +++ b/internal/elements.go @@ -143,7 +143,10 @@ func (resp *Response) Err() error { return nil } - var err error = resp.Error + var err error + if resp.Error != nil { + err = resp.Error + } if resp.ResponseDescription != "" { if err != nil { err = fmt.Errorf("%v (%w)", resp.ResponseDescription, err)