From 9bc7a8f15b2fe9f3769c17f944609556b706f3da Mon Sep 17 00:00:00 2001
From: Simon Ser <contact@emersion.fr>
Date: Tue, 31 May 2022 16:11:08 +0200
Subject: [PATCH] internal: drop Multistatus.Get

This is now unused.
---
 internal/elements.go      | 16 ----------------
 internal/elements_test.go | 10 ++++++++--
 2 files changed, 8 insertions(+), 18 deletions(-)

diff --git a/internal/elements.go b/internal/elements.go
index 1228bf2..6bcd6a0 100644
--- a/internal/elements.go
+++ b/internal/elements.go
@@ -6,7 +6,6 @@ import (
 	"fmt"
 	"net/http"
 	"net/url"
-	"path"
 	"strconv"
 	"strings"
 	"time"
@@ -101,21 +100,6 @@ func NewMultistatus(resps ...Response) *Multistatus {
 	return &Multistatus{Responses: resps}
 }
 
-func (ms *Multistatus) Get(p string) (*Response, error) {
-	// Clean the path to avoid issues with trailing slashes
-	p = path.Clean(p)
-	for i := range ms.Responses {
-		resp := &ms.Responses[i]
-		for _, h := range resp.Hrefs {
-			if path.Clean(h.Path) == p {
-				return resp, resp.Err()
-			}
-		}
-	}
-
-	return nil, fmt.Errorf("webdav: missing response for path %q", p)
-}
-
 // https://tools.ietf.org/html/rfc4918#section-14.24
 type Response struct {
 	XMLName             xml.Name   `xml:"DAV: response"`
diff --git a/internal/elements_test.go b/internal/elements_test.go
index 6bece02..f01904c 100644
--- a/internal/elements_test.go
+++ b/internal/elements_test.go
@@ -18,14 +18,20 @@ const exampleDeleteMultistatusStr = `<?xml version="1.0" encoding="utf-8" ?>
   </d:response>
 </d:multistatus>`
 
-func TestMultistatus_Get_error(t *testing.T) {
+func TestResponse_Err_error(t *testing.T) {
 	r := strings.NewReader(exampleDeleteMultistatusStr)
 	var ms Multistatus
 	if err := xml.NewDecoder(r).Decode(&ms); err != nil {
 		t.Fatalf("Decode() = %v", err)
 	}
 
-	_, err := ms.Get("/container/resource3")
+	if len(ms.Responses) != 1 {
+		t.Fatalf("expected 1 <response>, got %v", len(ms.Responses))
+	}
+
+	resp := ms.Responses[0]
+
+	err := resp.Err()
 	if err == nil {
 		t.Errorf("Multistatus.Get() returned a nil error, expected non-nil")
 	} else if httpErr, ok := err.(*HTTPError); !ok {