1f349/go-webdav
4
0
Fork 0
mirror of https://github.com/1f349/go-webdav.git synced 2024-12-22 16:24:14 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: Response body was not closed causing the goroutine leak

Browse Source
This commit is contained in:
myml 2022-06-18 02:51:01 +08:00 committed by Simon Ser
parent db966a275c
commit e0764c06a3
1 changed files with 31 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

41
client.go
View File

@ -193,8 +193,13 @@ func (c *Client) Create(name string) (io.WriteCloser, error) {
done := make(chan error, 1) done := make(chan error, 1)
go func() { go func() {
_, err := c.ic.Do(req) resp, err := c.ic.Do(req)
done <- err if err != nil {
done <- err
return
}
resp.Body.Close()
done <- nil
}() }()
return &fileWriter{pw, done}, nil return &fileWriter{pw, done}, nil
@ -206,8 +211,12 @@ func (c *Client) RemoveAll(name string) error {
return err return err
} }
_, err = c.ic.Do(req) resp, err := c.ic.Do(req)
return err if err != nil {
return err
}
resp.Body.Close()
return nil
} }
func (c *Client) Mkdir(name string) error { func (c *Client) Mkdir(name string) error {
@ -216,8 +225,12 @@ func (c *Client) Mkdir(name string) error {
return err return err
} }
_, err = c.ic.Do(req) resp, err := c.ic.Do(req)
return err if err != nil {
return err
}
resp.Body.Close()
return nil
} }
func (c *Client) CopyAll(name, dest string, overwrite bool) error { func (c *Client) CopyAll(name, dest string, overwrite bool) error {
@ -229,8 +242,12 @@ func (c *Client) CopyAll(name, dest string, overwrite bool) error {
req.Header.Set("Destination", c.ic.ResolveHref(dest).String()) req.Header.Set("Destination", c.ic.ResolveHref(dest).String())
req.Header.Set("Overwrite", internal.FormatOverwrite(overwrite)) req.Header.Set("Overwrite", internal.FormatOverwrite(overwrite))
_, err = c.ic.Do(req) resp, err := c.ic.Do(req)
return err if err != nil {
return err
}
resp.Body.Close()
return nil
} }
func (c *Client) MoveAll(name, dest string, overwrite bool) error { func (c *Client) MoveAll(name, dest string, overwrite bool) error {
@ -242,6 +259,10 @@ func (c *Client) MoveAll(name, dest string, overwrite bool) error {
req.Header.Set("Destination", c.ic.ResolveHref(dest).String()) req.Header.Set("Destination", c.ic.ResolveHref(dest).String())
req.Header.Set("Overwrite", internal.FormatOverwrite(overwrite)) req.Header.Set("Overwrite", internal.FormatOverwrite(overwrite))
_, err = c.ic.Do(req) resp, err := c.ic.Do(req)
return err if err != nil {
return err
}
resp.Body.Close()
return nil
} }