From 53041f4ac7782e386bda1844adf7fd847b7225d3 Mon Sep 17 00:00:00 2001 From: MrMelon54 Date: Thu, 24 Aug 2023 16:03:45 +0100 Subject: [PATCH] Remove the useless hijack call --- cmd/violet/serve.go | 2 +- target/route.go | 8 -------- 2 files changed, 1 insertion(+), 9 deletions(-) diff --git a/cmd/violet/serve.go b/cmd/violet/serve.go index 2dd4a18..53b4adf 100644 --- a/cmd/violet/serve.go +++ b/cmd/violet/serve.go @@ -39,7 +39,7 @@ func (s *serveCmd) Usage() string { ` } -func (s *serveCmd) Execute(ctx context.Context, f *flag.FlagSet, _ ...interface{}) subcommands.ExitStatus { +func (s *serveCmd) Execute(_ context.Context, _ *flag.FlagSet, _ ...interface{}) subcommands.ExitStatus { log.Println("[Violet] Starting...") if s.configPath == "" { diff --git a/target/route.go b/target/route.go index 3926eca..506583b 100644 --- a/target/route.go +++ b/target/route.go @@ -172,14 +172,6 @@ func (r Route) internalServeHTTP(rw http.ResponseWriter, req *http.Request) { if resp.Body != nil { _, err := io.Copy(rw, resp.Body) if err != nil { - // hijack and close upon error - if h, ok := rw.(http.Hijacker); ok { - hijack, _, err := h.Hijack() - if err != nil { - return - } - _ = hijack.Close() - } return } }