WIP: Refactor entire hosts reading and writing code #1

melon · 2024-01-12T13:34:57Z

melon commented

2024-01-12 13:34:57 +00:00

I started refactoring the host reading and writing code. This consists mostly of improvements in readability and performance.

melon added the

enhancement

label 2024-01-12 13:34:57 +00:00

melon added 1 commit 2024-01-12 13:34:57 +00:00

Refactor entire hosts reading and writing code 6238999c08

alfred self-assigned this 2024-01-15 14:51:20 +00:00

alfred requested review from alfred 2024-01-20 22:12:27 +00:00

alfred refused to review 2024-01-20 22:14:21 +00:00

alfred requested changes 2024-01-20 22:15:34 +00:00

alfred left a comment

@melon You have some stuff todo.

hosts/comment-reader.go

						
				@ -0,0 +9,4 @@

					r    io.Reader

					over []byte

					mark byte

					hit  bool

alfred commented

2024-01-20 22:06:33 +00:00

Whats this used for (hit)?
It's only checked in one place.

Whats this used for (hit)? It's only checked in one place.

alfred marked this conversation as resolved

hosts/entry.go

						
				@ -0,0 +58,4 @@

				func ParseEntry(line io.Reader) (entry Entry, err error) {

					cr := NewCommentReader(line, '#')

					sc := bufio.NewScanner(cr)

alfred commented

2024-01-20 22:11:45 +00:00

Support a larger buffer size if needed (Extra command line arg and/or env variable).

https://stackoverflow.com/questions/39859222/golang-how-to-overcome-scan-buffer-limit-from-bufio

Support a larger buffer size if needed (Extra command line arg and/or env variable). https://stackoverflow.com/questions/39859222/golang-how-to-overcome-scan-buffer-limit-from-bufio

hosts/file.go

						
				@ -0,0 +28,4 @@

					}

					defer theFile.Close()

					sc := bufio.NewScanner(theFile)

alfred commented

2024-01-20 22:11:56 +00:00

Support a larger buffer size if needed (Extra command line arg and/or env variable).

https://stackoverflow.com/questions/39859222/golang-how-to-overcome-scan-buffer-limit-from-bufio

Support a larger buffer size if needed (Extra command line arg and/or env variable). https://stackoverflow.com/questions/39859222/golang-how-to-overcome-scan-buffer-limit-from-bufio