alfred
/
HostPersister
1
0
Fork 1
Code Issues Pull Requests 1 Packages Projects Releases Wiki Activity

Refactor entire hosts reading and writing code #1

Open
melon wants to merge 2 commits from melon/HostPersister:master into master
pull from: melon/HostPersister:master
merge into: alfred:master
Conversation 0 Commits 2 Files Changed 10 +368 -200
melon commented 2024-01-12 13:34:57 +00:00
Collaborator
Copy Link

I started refactoring the host reading and writing code. This consists mostly of improvements in readability and performance.

I started refactoring the host reading and writing code. This consists mostly of improvements in readability and performance.
melon added the
enhancement
 label 2024-01-12 13:34:57 +00:00
melon added 1 commit 2024-01-12 13:34:57 +00:00
alfred self-assigned this 2024-01-15 14:51:20 +00:00
alfred requested review from alfred 2024-01-20 22:12:27 +00:00
alfred refused to review 2024-01-20 22:14:21 +00:00
alfred requested changes 2024-01-20 22:15:34 +00:00
alfred left a comment
Owner
Copy Link

@melon You have some stuff todo.

@melon You have some stuff todo.
hosts/comment-reader.go
@ -0,0 +9,4 @@
r io.Reader
over []byte
mark byte
hit bool
alfred commented 2024-01-20 22:06:33 +00:00
Owner
Copy Link

Whats this used for (hit)?
It's only checked in one place.

Whats this used for (hit)? It's only checked in one place.
alfred marked this conversation as resolved
hosts/entry.go
@ -0,0 +58,4 @@
func ParseEntry(line io.Reader) (entry Entry, err error) {
cr := NewCommentReader(line, '#')
sc := bufio.NewScanner(cr)
alfred commented 2024-01-20 22:11:45 +00:00
Owner
Copy Link

Support a larger buffer size if needed (Extra command line arg and/or env variable).

https://stackoverflow.com/questions/39859222/golang-how-to-overcome-scan-buffer-limit-from-bufio

Support a larger buffer size if needed (Extra command line arg and/or env variable). https://stackoverflow.com/questions/39859222/golang-how-to-overcome-scan-buffer-limit-from-bufio
hosts/file.go
@ -0,0 +28,4 @@
}
defer theFile.Close()
sc := bufio.NewScanner(theFile)
alfred commented 2024-01-20 22:11:56 +00:00
Owner
Copy Link

Support a larger buffer size if needed (Extra command line arg and/or env variable).

https://stackoverflow.com/questions/39859222/golang-how-to-overcome-scan-buffer-limit-from-bufio

Support a larger buffer size if needed (Extra command line arg and/or env variable). https://stackoverflow.com/questions/39859222/golang-how-to-overcome-scan-buffer-limit-from-bufio
melon was assigned by alfred 2024-01-20 22:16:29 +00:00
alfred removed their assignment 2024-01-20 22:16:37 +00:00
melon added 1 commit 2024-01-21 00:23:29 +00:00
This pull request can be merged automatically.
You are not authorized to merge this pull request.
You can also view command line instructions.

Step 1:

From your project repository, check out a new branch and test the changes.
git checkout -b melon-master master
git pull master

Step 2:

Merge the changes and update on Gitea.
git checkout master
git merge --no-ff melon-master
git push origin master
Sign in to join this conversation.
Reviewers
No reviewers
alfred
Labels
Clear labels   
bug

Something is not working

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
help wanted

Need some help

  
invalid

Something is wrong

  
question

More information is needed

  
wontfix

This won't be fixed

No Label
bug
duplicate
enhancement
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
melon
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: alfred/HostPersister#1
No description provided.
Delete Branch "melon/HostPersister:master"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?