melon/tokidoki
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Remove stat call from happy path

Browse Source 
Just try to read the file, use it if it works. Only if the file does
not exist, create default address book and try again.
This commit is contained in:
Conrad Hoffmann 2022-03-16 15:02:18 +01:00
parent 86359a5e11
commit e5db18e289
1 changed files with 3 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
storage/filesystem.go
View File

@ -154,17 +154,15 @@ func (b *filesystemBackend) AddressBook(ctx context.Context) (*carddav.AddressBo
return nil, err return nil, err
} }
path = filepath.Join(path, "default.json") path = filepath.Join(path, "default.json")
_, err = os.Stat(path)
data, err := ioutil.ReadFile(path)
if os.IsNotExist(err) { if os.IsNotExist(err) {
err = createDefaultAddressBook(path) err = createDefaultAddressBook(path)
if err != nil { if err != nil {
return nil, err return nil, err
} }
} else if err != nil { data, err = ioutil.ReadFile(path)
return nil, fmt.Errorf("error opening address book: %s", err.Error())
} }
data, err := ioutil.ReadFile(path)
if err != nil { if err != nil {
return nil, fmt.Errorf("error opening address book: %s", err.Error()) return nil, fmt.Errorf("error opening address book: %s", err.Error())
} }