alfred/HostPersister
1
0
Fork 1
Code Issues Pull Requests 1 Packages Projects Releases Wiki Activity

WIP: Refactor entire hosts reading and writing code #1

Draft
melon wants to merge 2 commits from melon/HostPersister:master into master
pull from: melon/HostPersister:master
merge into: alfred:master
Conversation 0 Commits 2 Files Changed 10 +2 -3
1 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit fc757fa0a0 - Show all commits

5
hosts/comment-reader.go
View File

@ -9,17 +9,16 @@ type CommentReader struct {
r io.Reader
over []byte
mark byte
hit bool
}
alfred marked this conversation as resolved
alfred commented 2024-01-20 22:06:33 +00:00
Review
Copy Link

Whats this used for (hit)?
It's only checked in one place.

Whats this used for (hit)? It's only checked in one place.
var _ io.Reader = &CommentReader{}
func NewCommentReader(r io.Reader, mark byte) *CommentReader {
return &CommentReader{r, nil, mark, false}
return &CommentReader{r, nil, mark}
}
func (c *CommentReader) Read(p []byte) (n int, err error) {
if c.hit {
if c.over != nil {
return 0, io.EOF
}
n, err = c.r.Read(p)